Reviewer: Dorian Raymer
Review Scope: The Data Exchange prototype results and the DOxygen link - especially the sequence diagrams and the code.
Summary Material
The Data Exchange CI1 page is a nicely organized plan of attack. All sub tasks derive from the official task lists prominently presented at the head of the page.
The subtasks are decomposed into bite sized development or research efforts.
The sequence diagrams in the Data Exchange Doxygen documentation are very useful for getting the picture that there are a lot of components talking to each other. The component names denote the their purpose well.
I was able to get a decent understanding of what was going on from this material.
Relevance
This prototype is a very relevant consideration for COI developers. The Data Exchange is currently the 'biggest customer' of the messaging service client adapter (Magnet) and feedback on real usage of Magnet is very valuable information to consider while growing Magnet's design.
Issues To Be Addressed
For this period, the issues are sufficiently addressed. There was an impressive amount of work produced considering the magnitude of what was tasked.
The code documentation is quite extensive. One thing that would be useful is a set of directions explaining exactly how to run your own data exchange system for developers.
Insights
Seeing the complex interactions emerge from the simple set of communication patterns in magnet is very interesting. The successful usage scenarios are exciting, and the deficiencies are observed and noted.
Further digestion of the pubsub/subscription services developed is definitely in order. I personally plan on reviewing this prototype again when considering exchange point application design for COI, and related tasks. I have a suspicion that some aspects of pubsub and notification will be general capabilities of COI...